Skip to content

#278 updating faraday to fix issue when param value is an empty array #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

senid231
Copy link
Member

@senid231 senid231 commented May 24, 2018

fix #278

Handling of empty array as parameter value was fixed in faraday with lostisland/faraday/pull/801

jsonapi spec says that filters implementation can be different so we need to support all cases - even sending an empty array

@senid231 senid231 self-assigned this May 24, 2018
@senid231 senid231 requested review from chingor13 and kylerippey May 24, 2018 09:06
@senid231 senid231 added the bug label May 25, 2018
@senid231 senid231 merged commit 2f5db2c into JsonApiClient:master May 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter parameters set to [] are discarded
1 participant